Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use verbosity instead of iverbosity in PH and EPW calculation #633

Merged
merged 2 commits into from
May 25, 2021

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Dec 14, 2020

Fix #606

The iverbosity is obsolete and found causing ph.x failed in qe-6.6.

@unkcpz unkcpz force-pushed the fix/606 branch 2 times, most recently from 1b2c9ad to 06dd08c Compare December 14, 2020 08:36
The iverbosity is obsolete and found causing ph.x failed in qe-6.6.
The `verbosity` is now set(hard code) to `high` as default.
@sphuber
Copy link
Contributor

sphuber commented Dec 14, 2020

Do you know when iverbosity was deprecated and removed, and especially in what version of QE verbosity was added? This is important because we need to know if this change would essentially be dropping support for certain QE versions. Also, I just checked that we also still use iverbosity in the PwCalculation and CpCalculation plugins, but I no longer find that option in the documentation of QE v6.3 or later.

@unkcpz
Copy link
Member Author

unkcpz commented Dec 14, 2020

Do you know when iverbosity was deprecated and removed, and especially in what version of QE verbosity was added?

I did a quick search and can't find the details. I guess the answer will in the source code anyway, I will make more investigate.

@atztogo
Copy link
Contributor

atztogo commented May 23, 2021

@sphuber
Copy link
Contributor

sphuber commented May 25, 2021

did a quick search and can't find the details. I guess the answer will in the source code anyway, I will make more investigate.

I ran through the source code and it seems it was changed in commit a7ef3557fb946e6c226aaa4c96b1fabed0e12346 of the QE source code, which was released with v5.2. I think that version is old enough that we can simply replace the value here and no longer support the old flag. The documentation at that time that contains a reference to the commit: https://gitlab.com/QEF/q-e/-/blob/qe-5.2.0/PHonon/Doc/INPUT_PH.def

@sphuber sphuber self-requested a review May 25, 2021 08:46
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @unkcpz

@sphuber sphuber merged commit f4528af into aiidateam:develop May 25, 2021
@unkcpz unkcpz deleted the fix/606 branch May 25, 2021 09:02
@atztogo
Copy link
Contributor

atztogo commented May 25, 2021

Thanks @unkcpz and @sphuber.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iverbosity is not working in ph.x 6.6 anymore
3 participants