Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PwBaseWorkChain: Fix protocols #635

Merged
merged 1 commit into from
Dec 15, 2020
Merged

PwBaseWorkChain: Fix protocols #635

merged 1 commit into from
Dec 15, 2020

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented Dec 15, 2020

Fixes two issues with the PwBaseWorkChain protocol:

  • Use 'SSSP/1.1/PBE/precision' for protocol precise.
  • Fix typo in meta_parameters.

@mbercx mbercx requested a review from sphuber December 15, 2020 13:08
sphuber
sphuber approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@sphuber sphuber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Here, have an emoji 🎩

@sphuber sphuber merged commit 57b282e into aiidateam:develop Dec 15, 2020
@mbercx
Copy link
Member Author

mbercx commented Dec 15, 2020

All good. Here, have an emoji 🎩

A @sphuber emoji! 😱
I will treasure it always. 🤤

@mbercx mbercx deleted the fix/precise-protocol branch December 15, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphuber sphuber sphuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbercx @sphuber