PwParser: Add support for QE v7.0
#774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbercx
force-pushed
the
new/759/qe-v7.0
branch
2 times, most recently
from
03f541c
to
568015c
Compare
Add the XML schema for Quantum ESPRESSO v7.0, along with a corresponding test for the parsing. Because the `.xsd` filename in the XML output of QE v7.0 is incorrect, a check is also added in the `get_schema_filename` function to see if the user was running QE v7.0. In that case, the correct filename is returned. We also use `pytest.mark.parametrize` to condense all the XML schema tests into one.
mbercx
force-pushed
the
new/759/qe-v7.0
branch
from
568015c
to
b723e9b
Compare
sphuber
requested changes
Jan 28, 2022
tests/parsers/test_pw.py
Outdated
| '191206', | ||
| '200420', | ||
| '210716', | ||
| '211102', |
There was a problem hiding this comment.
Think you may have mistyped this. Shouldn't it be 211101 i.e. with a 1 at the end instead of a two. Also should probably rename the folder of the reference test files.
mbercx
force-pushed
the
new/759/qe-v7.0
branch
from
3ed05ce
to
4a8cbb5
Compare
sphuber
approved these changes
Jan 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the XML schema for Quantum ESPRESSO v7.0, along with a corresponding
test for the parsing.
Because the
.xsdfilename in the XML output of QE v7.0 is incorrect,a check is also added in the
get_schema_filenamefunction to see ifthe user was running QE v7.0. In that case, the correct filename is
returned.
We also use
pytest.mark.parametrizeto condense all the XML schematests into one.