Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devops: adopt PEP 621 and move build spec to pyproject.toml #779

Merged
merged 2 commits into from
Jan 29, 2022

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Jan 28, 2022

Fixes #778

Following PEP 621 it is now possible to fully define the build procedure
of your package in pyproject.toml. Since this PEP is now well
supported, and for example pip can use it, we migrate to it since it
provides a bunch of benefits:

  • No longer need the deprecated setup.py to install the package.
  • Version number is now dynamically fetched from the package. So the
    utility script to make sure the setup.json specifies the same
    version can be removed.
  • The MANIFEST.in is no longer necessary. The flit build tool will
    automatically include anything. The pyproject.toml has a tool
    section for flit that excludes the tests and docs folders.

Following PEP 621 it is now possible to fully define the build procedure
of your package in `pyproject.toml`. Since this PEP is now well
supported, and for example `pip` can use it, we migrate to it since it
provides a bunch of benefits:

 * No longer need the deprecated `setup.py` to install the package.
 * Version number is now dynamically fetched from the package. So the
   utility script to make sure the `setup.json` specifies the same
   version can be removed.
 * The `MANIFEST.in` is no longer necessary. The `flit` build tool will
   automatically include anything. The `pyproject.toml` has a tool
   section for `flit` that excludes the `tests` and `docs` folders.
Copy link
Member

@mbercx mbercx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

party

@sphuber sphuber merged commit e407c4b into develop Jan 29, 2022
@sphuber sphuber deleted the fix/778/pep-621-build branch January 29, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move package build procedure to pyproject.toml following PEP 621
2 participants