CI: update the GHA ci.yml workflow
#780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow is cleaned with various small changes: * Use strings for Python version specifiers. They should be treated as strings, because floats will cause problems. For example the float `3.10` would be normalized to `3.1` which is not what is intended. * No need for pipe symbol if `run` is single command * Update `actions/checkout` action to `v2` * Remove unused `id` attribute of the caching step * Install and or update `pip`, `setuptools` and `wheel` before installing the package. Without `wheel` dependencies will have to be installed using the legacy method. * Remove explicit installation of postgres through system dependencies as this is already setup as a service. * Remove explicit creation of PostgreSQL database through the service step as this will be done on the fly when invoking `pytest`.
mbercx
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow is cleaned with various small changes:
strings, because floats will cause problems. For example the float
3.10would be normalized to3.1which is not what is intended.runis single commandactions/checkoutaction tov2idattribute of the caching steppip,setuptoolsandwheelbeforeinstalling the package. Without
wheeldependencies will have to beinstalled using the legacy method.
as this is already setup as a service.
step as this will be done on the fly when invoking
pytest.