Devops: fix the nightly build #784
Conversation
| id: tests | ||
| run: | ||
| pytest -sv tests | ||
|
|
||
| - name: Slack notification |
There was a problem hiding this comment.
Seems the workflow had been failing for a while now, but I didn't see any notifications in the Slack channel?
There was a problem hiding this comment.
Good point, not sure why because it used to work at some point, but looking at the syntax, it seems to rely on the steps.install and steps.tests identifiers. I had accidentally removed them so it would have failed, but they used to be there, so not sure why it wasn't working.
.github/workflows/develop.yml
Outdated
| id: install | ||
| run: | | ||
| pip install --upgrade setuptools | ||
| pip install --upgrade pip setuptools wheel | ||
| pip install git+https://github.com/aiidateam/aiida-core@develop#egg=aiida-core[atomic_tools] | ||
| pip install -e .[tests] | ||
| reentry scan |
There was a problem hiding this comment.
Do we still have to run reentry scan for the develop branch of aiida-core?
There was a problem hiding this comment.
Absolutely, removed it. This reminds me though that merging this now might not be a good idea, as it won't work as anticipated. The install from source of aiida-core will work but pip install -e .[tests] will then install with requirements of our own develop branch and that still specified something like aiida-core~=1.6 and so it will uninstall the develop branch of aiida-core. So we need a v2.0 release of aiida-core and then up our own requirements.
There was a problem hiding this comment.
Right, of course. So we'll put this PR as "blocked" for now? I'll start working on a branch to support aiida-core==2.0.
sphuber
force-pushed
the
fix/nightly-build
branch
3 times, most recently
from
e8b0006
to
506f308
Compare
sphuber
added
the
pr/blocked
The nightly build against the `develop` branch of `aiida-core` was failing at the installation of the Python dependencies when running against Python 3.7. The reason is that the current `develop` branch has dropped support for Python 3.7 and the `pip` is then failing to install a version of `pymatgen` that matches the dependency requirements. The solution is simply to not run against Python 3.7 anymore. In addition, as of `aiida-core==2.0` the `develop` branch has been renamed to `main` so the workflow is updated to install that branch. As a result, the workflow file is also renamed from `develop` to `nightly` as the term `develop` is no longer really applicable. Furthermore, the workflow is updated to match the exact same setup procedure as the `ci.yml` workflow which has also recently been updated.
sphuber
force-pushed
the
fix/nightly-build
branch
from
506f308
to
ed62f7e
Compare
sphuber
removed
the
pr/blocked
The nightly build against the
developbranch ofaiida-corewasfailing at the installation of the Python dependencies when running
against Python 3.7. The reason is that the current
developbranch hasdropped support for Python 3.7 and the
pipis then failing to installa version of
pymatgenthat matches the dependency requirements. Thesolution is simply to not run against Python 3.7 anymore.
In addition, as of
aiida-core==2.0thedevelopbranch has beenrenamed to
mainso the workflow is updated to install that branch. Asa result, the workflow file is also renamed from
developtonightlyas the term
developis no longer really applicable.Furthermore, the workflow is updated to match the exact same setup
procedure as the
ci.ymlworkflow which has also recently been updated.