Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Additional compatibility for aiida-core v2.0 #806

Merged
merged 1 commit into from
May 5, 2022

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented May 5, 2022

This commit adds some additional minor changes that simplify the code
and address deprecation warnings of aiida-core==2.0:

  • Adding the core. prefix to entry points from aiida-core.
  • Cleaning up the unnecessary dict=/list= keyword arguments from the
    constructor of Dict and List nodes.

This commit adds some additional minor changes that simplify the code
and address deprecation warnings of `aiida-core==2.0`:

* Adding the `core.` prefix to entry points from `aiida-core`.
* Cleaning up the unnecessary `dict=`/`list=` keyword arguments from the
  constructor of `Dict` and `List` nodes.
@sphuber sphuber requested a review from mbercx May 5, 2022 11:56
Copy link
Member

@mbercx mbercx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sphuber sphuber merged commit 77ac84a into develop May 5, 2022
@sphuber sphuber deleted the fix/compatibility-aiida-core-2.0 branch May 5, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants