Dependencies: Add lower requirement aiida-core>=2.0.4
#841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release `aiida-core==2.0` updated the `local_copy_list` syntax to allow specifying folders with the promise to copy them recursively. However, due to a bug, the relative source path was included in the target, essentially duplicating the nesting. This would cause calculations that restarted from a `retrieved` folder, such as the `Q2rCalculation` to fail. The bug was fixed in `aiida-core==2.0.4` so we set that as a lower requirement.
sphuber
force-pushed
the
fix/840/q2r-parent-folder
branch
from
f39a72d
to
1198871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #840
The release
aiida-core==2.0updated thelocal_copy_listsyntax to allow specifying folders with the promise to copy them recursively. However, due to a bug, the relative source path was included in the target, essentially duplicating the nesting. This would cause calculations that restarted from aretrievedfolder, such as theQ2rCalculationto fail. The bug was fixed inaiida-core==2.0.4so we set that as a lower requirement.