-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Feature: XspectraCrystalWorkChain
#888
Add Feature: XspectraCrystalWorkChain
#888
Commits on May 9, 2022
-
Added CalcJob implementations of the xspectra.x executable and upf2plotcore.sh shell script from the Quantum ESPRESSO library
Configuration menu - View commit details
-
Copy full SHA for 11e9c65 - Browse repository at this point
Copy the full SHA 11e9c65View commit details -
Upload of Parser classes for new CalcJobs
Added Parser classes for the xspectra.x executable and upf2plotcore.sh shell script from the Quantum ESPRESSO library
Configuration menu - View commit details
-
Copy full SHA for 0c6373a - Browse repository at this point
Copy the full SHA 0c6373aView commit details -
Added entry points for both CalcJob and Parser classes required for XSpectra post-processing calculations
Configuration menu - View commit details
-
Copy full SHA for 5d14f11 - Browse repository at this point
Copy the full SHA 5d14f11View commit details
Commits on May 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4c36b55 - Browse repository at this point
Copy the full SHA 4c36b55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e62357 - Browse repository at this point
Copy the full SHA 0e62357View commit details
Commits on May 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8b73bd9 - Browse repository at this point
Copy the full SHA 8b73bd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd4274a - Browse repository at this point
Copy the full SHA bd4274aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee2e9ef - Browse repository at this point
Copy the full SHA ee2e9efView commit details
Commits on Jun 6, 2022
-
Update src/aiida_quantumespresso/calculations/xspectra.py
Change 'spectra_data' output to 'spectra' Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Configuration menu - View commit details
-
Copy full SHA for 6c39561 - Browse repository at this point
Copy the full SHA 6c39561View commit details -
Change the caplitalization for XSpectraCalculation to XspectraCalculation Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Configuration menu - View commit details
-
Copy full SHA for 0c20f58 - Browse repository at this point
Copy the full SHA 0c20f58View commit details -
Correct the capitalization of XSpectraParser to XspectraParser Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Configuration menu - View commit details
-
Copy full SHA for fdbddaa - Browse repository at this point
Copy the full SHA fdbddaaView commit details -
Correct the capitalization of XSpectraCalculation to XspectraCalculation Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Configuration menu - View commit details
-
Copy full SHA for 5f7844e - Browse repository at this point
Copy the full SHA 5f7844eView commit details -
Correct the capitalization of XSpectraParser to XspectraParser Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Configuration menu - View commit details
-
Copy full SHA for 811066b - Browse repository at this point
Copy the full SHA 811066bView commit details
Commits on Jun 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a41de8c - Browse repository at this point
Copy the full SHA a41de8cView commit details
Commits on Jun 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a7390e3 - Browse repository at this point
Copy the full SHA a7390e3View commit details -
XspectraParser
: Added parsing for spin-polarised calculations, remo……ved redundant file loop, and added new error code
Configuration menu - View commit details
-
Copy full SHA for 3c83c4d - Browse repository at this point
Copy the full SHA 3c83c4dView commit details
Commits on Jun 14, 2022
-
XspectraCalculation
: Fixed wording of error codesFixed the terms used in the XSpectra-specific error codes in order to make them easier to read.
Configuration menu - View commit details
-
Copy full SHA for f12cf09 - Browse repository at this point
Copy the full SHA f12cf09View commit details
Commits on Jun 20, 2022
-
XspectraCalculation
: Updated_Plotcore_FILENAME
Changed filename assigned to `_Plotcore_FILENAME` from `plotcore.out` to `stdout` in order to work properly with the `aiida-shell` plugin.
Configuration menu - View commit details
-
Copy full SHA for d5530c6 - Browse repository at this point
Copy the full SHA d5530c6View commit details -
XspectraParser
: Fixed various errors inparse
Made corrections to the parsing of various output parameters (e.g. energy levels and associated units) in both spin-polarised and unpolarised cases. An additional parameter `lsda` is also added to report explicitly the case of spin polarisation.
Configuration menu - View commit details
-
Copy full SHA for 75ba5d8 - Browse repository at this point
Copy the full SHA 75ba5d8View commit details -
Added various tests for
XspectraParser
Adds tests of the `XspectraParser`, covering spin-polarised and non-spin-polarised cases, interrupted calculations, and XSpectra-specific error codes 313 and 314.
Configuration menu - View commit details
-
Copy full SHA for 5f4bd99 - Browse repository at this point
Copy the full SHA 5f4bd99View commit details
Commits on Jul 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c6f4485 - Browse repository at this point
Copy the full SHA c6f4485View commit details
Commits on Sep 2, 2022
-
XspectraCalculation
+XspectraParser
: Added Various Extra FeaturesAdds the following features to the `XspectraCalculation` and `XspectraParser` classes: - A save file ('xanes.sav') is now reserved by default and is printed at the end of each calculation run or after a designated time limit. The file can then be used for re-starting halted calculations or re-plotting spectra from previously-finished calculations. - The `XspectraCalculation` class now copies the save file from a parent calculation if the calculation type is itself an XspectraCalculation, thus re-starts and re-plot runs are handled automatically. - An error code has been added (315) for calculations which safely exit after reaching their time limit, thus enabiling a restart. - Additional information is now included in the `output_parameters` node (e.g. the polarisation vectors used and whether the calculation was set to "xonly_plot").
Configuration menu - View commit details
-
Copy full SHA for 875fa58 - Browse repository at this point
Copy the full SHA 875fa58View commit details -
Tests: Update
XspectraParser
Tests for Latest CommitUpdates `XspectraParser` tests to work with changes made in a previous commit (commit 875fa58) and adds a new test for error code 315 (job exceeded time limit)
Configuration menu - View commit details
-
Copy full SHA for 793b391 - Browse repository at this point
Copy the full SHA 793b391View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec841e4 - Browse repository at this point
Copy the full SHA ec841e4View commit details -
Merge branch 'develop' of https://github.com/PNOGillespie/aiida-quant…
…umespresso into develop
Configuration menu - View commit details
-
Copy full SHA for 8427a55 - Browse repository at this point
Copy the full SHA 8427a55View commit details
Commits on Sep 12, 2022
-
XspectraCalculation
: Fix unnecessary bracketingAddresses aiidateam#837 Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Configuration menu - View commit details
-
Copy full SHA for f0b00a5 - Browse repository at this point
Copy the full SHA f0b00a5View commit details -
XspectraCalculation
: Minor change togamma_file
input checkAddresses PR aiidateam#837 Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Configuration menu - View commit details
-
Copy full SHA for 63b32f6 - Browse repository at this point
Copy the full SHA 63b32f6View commit details -
XspectraCalculation
: Change of walltime error codeAddresses PR aiidateam#837 Changes error code from 315 to 400 to match conventions Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Configuration menu - View commit details
-
Copy full SHA for 746770e - Browse repository at this point
Copy the full SHA 746770eView commit details -
XspectraParser
: Change of walltime error codeAddresses PR aiidateam#837 Required for commit aiidateam@746770e Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Configuration menu - View commit details
-
Copy full SHA for 6eb8ace - Browse repository at this point
Copy the full SHA 6eb8aceView commit details -
Tests: Update of error code text
Addresses PR aiidateam#837 Required with commit aiidateam@746770e Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Configuration menu - View commit details
-
Copy full SHA for 6742ff3 - Browse repository at this point
Copy the full SHA 6742ff3View commit details -
XspectraCalculation
: Cleanup code forrestart_flag
Addresses PR aiidateam#837 Cleans-up the code for detecting if the parent calculation was an `XspectraCalculation` Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Configuration menu - View commit details
-
Copy full SHA for 8b84c55 - Browse repository at this point
Copy the full SHA 8b84c55View commit details -
Tests: Trim contents of
aiida.out
forfailed_walltime
Addresses comment for PR aiidateam#837: aiidateam#837 (review) Safely trims down the file length of the stdout file for `failed_timeout` test of `XspectraParser`
Configuration menu - View commit details
-
Copy full SHA for ab9ba9f - Browse repository at this point
Copy the full SHA ab9ba9fView commit details -
Merge branch 'develop' of https://github.com/PNOGillespie/aiida-quant…
…umespresso into local develop
Configuration menu - View commit details
-
Copy full SHA for a6ac39a - Browse repository at this point
Copy the full SHA a6ac39aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e0529ec - Browse repository at this point
Copy the full SHA e0529ecView commit details
Commits on Sep 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5a0e90f - Browse repository at this point
Copy the full SHA 5a0e90fView commit details
Commits on Sep 27, 2022
-
Update tests/parsers/test_xspectra.py
Correct text of docstring for `test_xspectra_failed_timeout` Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Configuration menu - View commit details
-
Copy full SHA for 767e2d6 - Browse repository at this point
Copy the full SHA 767e2d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae91712 - Browse repository at this point
Copy the full SHA ae91712View commit details
Commits on Oct 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a2c1321 - Browse repository at this point
Copy the full SHA a2c1321View commit details
Commits on Oct 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for dd73851 - Browse repository at this point
Copy the full SHA dd73851View commit details
Commits on Oct 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2a73bd5 - Browse repository at this point
Copy the full SHA 2a73bd5View commit details -
XspectraParser
: Fix bugs in parsing vector/coord systemAdds information on the coordinate system used in the XSpectra calculation (either crystallographic or Cartesian). Also addresses a bug spotted in the stdout of XSpectra itself, where the epsilon/k-vector is reported by the code during the `read_save_file` subroutine as being in `[Cartesian frame]` regardless of the coordinate system used by the parent XSpectra calculation. Because of this, calculations where `xonly_plot=.true.` cannot meaningfully have metadata for the coordinate system used by the calculation recorded in the `output_parameters` dictionary by the parser. This fix also addresses the fact that the epsilon/k-vector is essentially reported twice in the event of a calculation restart: once when the input file is read and a second time when the save file is read.
Configuration menu - View commit details
-
Copy full SHA for b2c4b83 - Browse repository at this point
Copy the full SHA b2c4b83View commit details -
Hotfix: Update Previous Commit to
XspectraParser
Updates commit 9ef620c Previous commit stated that when reading the save file, XSpectra prints the epsilon/k-vector stored in the save file as being in Cartesian coordinates regardless the coordinate system used in the parent calculation. This statement was incorrect, as XSpectra always records the epsilon vector in cartesian coordinates. The parser now correctly records the `eps_k_vector_coords` entry in the event of re-plot calculations while skipping the entry for calculation restarts, since the epsilon/k-vector used is reported with the relevant coordinate system at the beginning of the stdout.
Configuration menu - View commit details
-
Copy full SHA for d6577fa - Browse repository at this point
Copy the full SHA d6577faView commit details -
XspectraParser
: Improve reliability of parsing methodImproves the reliability of parsing information in the `XspectraParser` by collecting information from the CalcJob node's `parameter` node instead of using the stdout.
Configuration menu - View commit details
-
Copy full SHA for af1822d - Browse repository at this point
Copy the full SHA af1822dView commit details -
XspectraParser
: Updates to parser dict keys and testsFor the `XspectraParser` and related tests: * Changes the Parser to retrieve various information from the inputs of the CalcJob node rather than the stdout, since some information (e.g. polarisation vector and coordinate system) are not reported reliably. * Changes some of the keys in the `output_parameters` dictionary. * Updates the Parser tests to work with the new changes to the Parser itself.
Configuration menu - View commit details
-
Copy full SHA for 42d66bb - Browse repository at this point
Copy the full SHA 42d66bbView commit details
Commits on Oct 28, 2022
-
XspectraParser
: Changeoutput_parameter
keys and add defaultsRequested for aiidateam#853 For parameters Parsed from the calculation input, the commit changes their keys to those used in the input parameters: * `epsilon_vectors` => `xepsilon` * `vector_coord_system` => `xcoordcrys` * `only_plot_spectrum` => `xonly_plot` Also adds default values for these keys which match those set by `xspectra.x` and updates the relevant parser tests.
Configuration menu - View commit details
-
Copy full SHA for df1def4 - Browse repository at this point
Copy the full SHA df1def4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bb7cbf - Browse repository at this point
Copy the full SHA 9bb7cbfView commit details -
Merge branch 'develop' of https://github.com/PNOGillespie/aiida-quant…
…umespresso into develop
Configuration menu - View commit details
-
Copy full SHA for 4a058f5 - Browse repository at this point
Copy the full SHA 4a058f5View commit details
Commits on Nov 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ee58a8f - Browse repository at this point
Copy the full SHA ee58a8fView commit details
Commits on Nov 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ab5559a - Browse repository at this point
Copy the full SHA ab5559aView commit details
Commits on Dec 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5c68963 - Browse repository at this point
Copy the full SHA 5c68963View commit details
Commits on Dec 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ede83a3 - Browse repository at this point
Copy the full SHA ede83a3View commit details
Commits on Jan 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d1c7d74 - Browse repository at this point
Copy the full SHA d1c7d74View commit details
Commits on Feb 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6bf3998 - Browse repository at this point
Copy the full SHA 6bf3998View commit details
Commits on Feb 14, 2023
-
Add Feature:
XspectraCrystalWorkChain
Adds a new WorkChain for `xspectra.x` calculations to compute a complete K-edge XANES for each element of a given structure using `pw.x` and `xspectra.x`. The WorkChain uses the following process flow: * Relax the given input structure using the `PwRelaxWorkChain` (optional). * Generate the core wavefunction of each ground-state pseudopotential for each absorbing element considered (requires AiiDA-Shell plugin). * Analyse the symmetry of the relaxed structure using `spglib`. Use the outputs of the analysis to prepare inputs for `XspectraCoreWorkChain` sub-processes. * Call the `XspectraCoreWorkChain` for each structure prepared in the previous step to generate the powder sample XANES for each identified absorbing atom site in the structure. * Compile all outputs from the `XspectraCoreWorkChain` sub-processes and return a single XANES spectrum for each element considered in the analysis. Excited-state and ground-state pseudopotentials presently must be provided using the input namespaces `core_hole_pseudos` and `gipaw_pseudos` respectively, taking the form of a Dict node with the format: {'{element} : {'core_hole' : {upf}, 'gipaw' : {upf}}} In addition to the final XANES spectra for each element, the powder spectrum of each absorbing atom calculated can be returned as output to the head WorkChain node with the optional input `return_all_powder_spectra` (`False` by default).
Configuration menu - View commit details
-
Copy full SHA for d4a2845 - Browse repository at this point
Copy the full SHA d4a2845View commit details
Commits on Feb 15, 2023
-
XspectraCrystalWorkChain
: Addcore_wfc_data
input namespaceAdds an input namespace `core_wfc_data` which can be used to provide already-computed core wavefunction data files for each element. Must use the format: {core_wfc_data : {"{element}" : {node}}}
Configuration menu - View commit details
-
Copy full SHA for bceb7f6 - Browse repository at this point
Copy the full SHA bceb7f6View commit details -
XspectraCrystalWorkChain
: Addprotocol
testsAdds tests for the `get_builder_from_protocol` method of the `XspectraCrystalWorkChain`
Configuration menu - View commit details
-
Copy full SHA for 58a290e - Browse repository at this point
Copy the full SHA 58a290eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9e6879 - Browse repository at this point
Copy the full SHA b9e6879View commit details
Commits on Mar 20, 2023
-
XspectraCrystalWorkChain
: Clean up and simplify codeRemoves redundant code in `setup` and `get_xspectra_structures` Co-authored-by: Xing Wang <xingwang1991@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6d9506d - Browse repository at this point
Copy the full SHA 6d9506dView commit details -
XspectraCrystalWorkChain
: Fix typo invalidiate_inputs
Co-authored-by: Xing Wang <xingwang1991@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 28c65ac - Browse repository at this point
Copy the full SHA 28c65acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 142a0b1 - Browse repository at this point
Copy the full SHA 142a0b1View commit details
Commits on Mar 21, 2023
-
XspectraCrystalWorkChain
: Requested Changes for PR (1)Addresses changes requested for PR aiidateam#888 (1): * Expands the docstring for `get_spectra_by_element` to describe input parameters and usage. * Fixes an oversight in `get_xspectra_structures` where the `standardized_structure` value was returned regardless of whether the structure was actually standardized by the CalcFunction. * Add a check for the `core_wfc_data` input to check for improperly-formatted file content. * Modify the `elements_list` input to be a required input and correct all instances where data provenance was lost. Changes `get_builder_from_protocol()` to set `elements_list` automatically based on `pseudos` input if no `elements_list` is given * Correct all instances of `optimized_structure` and `relaxed_structure` to all be `optimized_structure` * Change from simply using `append_` to add all CoreWorkChains to the context and instead assign each their site indexes as keys (i.e. `self.ctx.site_{i}`) * Add a step to unassign the pseudopotential for the element of the absorbing atom if the element does not exist in the structure (e.g. for the case where only one atomic site of the element exists). * Change the `structure_preparation_settings` input to be a dynamic namespace instead of a single Dict node, thus ensuring data provenance is maintained.
Configuration menu - View commit details
-
Copy full SHA for 5964896 - Browse repository at this point
Copy the full SHA 5964896View commit details -
Tests
: Updatetest_crystal.yaml
Updates the `test_crystal.yaml` to include the required `elements_list` input generated by the protocol.
Configuration menu - View commit details
-
Copy full SHA for 14d2afa - Browse repository at this point
Copy the full SHA 14d2afaView commit details
Commits on Mar 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 41a5e40 - Browse repository at this point
Copy the full SHA 41a5e40View commit details -
Configuration menu - View commit details
-
Copy full SHA for dde5b4d - Browse repository at this point
Copy the full SHA dde5b4dView commit details