-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aiida-aimall to plugins.yaml #300
Conversation
|
hey @kmlefran , thanks for registering your plugin on the AiiDA plugin registry! I notice a warning about the python version in the docs built from the pull request https://aiidateam.github.io/aiida-registry/pr-preview/pr-300/aiida-aimall Can you comment on where that comes from / whether it is indeed a problem? |
Merge change from aiida-plugin-registry and re-add aiida-aimall
I tried adjusting some stuff in my packages pyproject.toml but seems like the same issue on the new preview. I'm not sure why that would be, on my end I have no issues installing. Maybe could be due to h5 headers in the aiida-dataframe tables dependency? But I don't understand why there is an error with the Python version in the preview. Sorry but I'm relatively new to developing packages. On my end, I was able to install my package no problem in a conda environment with conda create -n install_test python=3.11
conda activate install_test
conda install h5py # h5 headers
pip install --pre aiida-aimall |
Hey @kmlefran , thanks for looking into this. This is interesting, and I guess it suggest some issue on the side of the test done by the aiida registry. I will open an issue for this. In the meanwhile, happy to merge your PR as you confirm installation works fine. |
The reason is that docker image used to test build is based on our official To exactly reproduce how the checks are running, you can use |
Hi @kmlefran, can you try to loose on the python version to include py3.10 and make a release? Or there are py3.10 features you used in the plugin? |
Hi, sorry for the delay, just had a new baby so been busy. I've enabled Python 3.10 and created a new release. |
Thanks @kmlefran and congratulation! Once #314 is merged, the entrypoints will shown, the error is from an issue from aiida-registry side. |
Great, thanks! Also, unrelated to this PR but updated my defaults to best practice now after reviewing #314 |
Register aiida-aimall