Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aiida-aimall to plugins.yaml #300

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

kmlefran
Copy link
Contributor

Register aiida-aimall

Copy link

github-actions bot commented Jan 22, 2024

PR Preview Action v1.4.6
🚀 Deployed preview to https://aiidateam.github.io/aiida-registry/pr-preview/pr-300/
on branch gh-pages at 2024-02-01 16:34 UTC

@ltalirz
Copy link
Member

ltalirz commented Jan 31, 2024

hey @kmlefran , thanks for registering your plugin on the AiiDA plugin registry!

I notice a warning about the python version in the docs built from the pull request https://aiidateam.github.io/aiida-registry/pr-preview/pr-300/aiida-aimall

Can you comment on where that comes from / whether it is indeed a problem?

Merge change from aiida-plugin-registry and re-add aiida-aimall
@kmlefran kmlefran reopened this Feb 1, 2024
@kmlefran
Copy link
Contributor Author

kmlefran commented Feb 1, 2024

I tried adjusting some stuff in my packages pyproject.toml but seems like the same issue on the new preview. I'm not sure why that would be, on my end I have no issues installing. Maybe could be due to h5 headers in the aiida-dataframe tables dependency? But I don't understand why there is an error with the Python version in the preview. Sorry but I'm relatively new to developing packages.

On my end, I was able to install my package no problem in a conda environment with pip install --pre as the error message suggests the registry is having issues with.

conda create -n install_test python=3.11
conda activate install_test
conda install h5py # h5 headers
pip install --pre aiida-aimall

@ltalirz
Copy link
Member

ltalirz commented Feb 1, 2024

Hey @kmlefran , thanks for looking into this.

This is interesting, and I guess it suggest some issue on the side of the test done by the aiida registry. I will open an issue for this.

In the meanwhile, happy to merge your PR as you confirm installation works fine.

@ltalirz ltalirz self-requested a review February 1, 2024 17:31
@ltalirz ltalirz merged commit 0754d4c into aiidateam:master Feb 1, 2024
5 checks passed
@unkcpz
Copy link
Member

unkcpz commented Mar 18, 2024

The reason is that docker image used to test build is based on our official aiida-core-with-services image which pinned the python version to 3.10. Since in your package the minimal python version is pinned to 3.11, the check is fail.

To exactly reproduce how the checks are running, you can use aiida-core-with-services by docker, as documented in https://aiida.readthedocs.io/projects/aiida-core/en/latest/intro/run_docker.html. You'll get an identical environment as checks are running.

@unkcpz
Copy link
Member

unkcpz commented Mar 20, 2024

Hi @kmlefran, can you try to loose on the python version to include py3.10 and make a release? Or there are py3.10 features you used in the plugin?

@kmlefran
Copy link
Contributor Author

Hi, sorry for the delay, just had a new baby so been busy. I've enabled Python 3.10 and created a new release.

@unkcpz
Copy link
Member

unkcpz commented Apr 11, 2024

Thanks @kmlefran and congratulation!

Once #314 is merged, the entrypoints will shown, the error is from an issue from aiida-registry side.
The plugin details are now all shown, please take a look at the preview https://aiidateam.github.io/aiida-registry/pr-preview/pr-314

@unkcpz
Copy link
Member

unkcpz commented Apr 23, 2024

@kmlefran
Copy link
Contributor Author

Great, thanks! Also, unrelated to this PR but updated my defaults to best practice now after reviewing #314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants