-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aiida-mlip plugin #304
aiida-mlip plugin #304
Conversation
|
Hey @federicazanca , thanks for adding aiida-mlip to the registry! I noticed in the docs preview a few suggestions, could you have a look? https://aiidateam.github.io/aiida-registry/pr-preview/pr-304/ |
hey @unkcpz , when you have time, would you be able to have a look at why this is failing? |
Sure! I'll check it. |
Hi @federicazanca, I disable the preview action in dev-CI, the failed one is duplicate as the the preview from plugin-CI and only should be run for PR from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @federicazanca!
Although all tests passed, the installation test is not running since you didn't specify the pip_url
and the development status classifier is set to "alpha" (https://github.com/stfc/aiida-mlip/blob/18695f7793d99b5dd632bfa8d4a60057ffc64930/pyproject.toml#L18C6-L18C24)
I notice you already had the package published on pypi so I proposed the change to test installation, if everything goes fine you can see the plugin port details in the detail page.
Please also remember to update the development status in the pyproject.toml
file of aiida-mlip
to beta or higher once you think it is ready.
Co-authored-by: Jusong Yu <jusong.yeu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @federicazanca
thank you and I'll keep it updated, still working on some main features |
aiida-mlip plugin
machine learning interatomic potentials aiida plugin