Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load profile when running entrypoints check new #317

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Apr 11, 2024

Reimplemented of #314 with adding a waiting process to make sure the profile is ready.

Copy link

github-actions bot commented Apr 11, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://aiidateam.github.io/aiida-registry/pr-preview/pr-317/
on branch gh-pages at 2024-04-11 20:52 UTC

@unkcpz unkcpz marked this pull request as draft April 11, 2024 11:53
@unkcpz
Copy link
Member Author

unkcpz commented Apr 11, 2024

No idea why the profile still not loaded. The fallback solution is to use the temp profile.

@unkcpz unkcpz marked this pull request as ready for review April 11, 2024 20:21
@unkcpz unkcpz requested a review from khsrali April 12, 2024 11:20
@khsrali khsrali merged commit 678f517 into master Apr 19, 2024
5 checks passed
@unkcpz unkcpz deleted the load-profile-when-running-entrypoints-check-new branch April 23, 2024 09:24
@unkcpz
Copy link
Member Author

unkcpz commented Apr 23, 2024

Thanks for the review! @khsrali

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants