-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of tutorial material #278
First version of tutorial material #278
Conversation
bf47865
to
60ab18a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments up for discussion
Co-authored-by: ramirezfranciscof <ramirezfranciscof@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @ramirezfranciscof! Strange that me replying to this review makes GitHub start my own review. Is this because of my newly obtained admin powers? 💪 (EDIT: Nope, I most likely just messed up somehow 😭)
I'll start working on making the necessary changes now.
hey @pradyunsg is this right, that pip is downloading multiple versions of the same package 😬 ? from https://readthedocs.org/projects/aiida-tutorials/builds/12413063/ $ pip install --use-feature 2020-resolver --exists-action=w --no-cache-dir -r requirements.txt
...
Collecting nbformat
Downloading nbformat-5.0.8-py3-none-any.whl (172 kB)
Collecting nbclient
Downloading nbclient-0.5.1-py3-none-any.whl (65 kB)
Collecting nbclient
Downloading nbclient-0.5.0-py3-none-any.whl (65 kB)
Collecting nbformat
Downloading nbformat-5.0.7-py3-none-any.whl (170 kB)
Collecting nbformat
Downloading nbformat-5.0.6-py3-none-any.whl (170 kB)
Collecting nbformat
Downloading nbformat-5.0.5-py3-none-any.whl (170 kB)
Collecting nbformat
Downloading nbformat-5.0.4-py3-none-any.whl (169 kB)
Collecting nbformat
Downloading nbformat-5.0.3-py3-none-any.whl (169 kB)
Collecting nbformat
Downloading nbformat-5.0.2-py3-none-any.whl (169 kB)
Collecting nbformat
Downloading nbformat-4.4.0-py2.py3-none-any.whl (155 kB)
Command killed due to excessive memory consumption |
@ramirezfranciscof thanks for the review! I've already given the basics section a good revision, maybe you can have another look at this section? I'll work on the Quantum ESPRESSO part tomorrow! 😴 |
@ramirezfranciscof I've also reviewed the second part of the tutorial and made more adjustments. So the whole tutorial is once again ready for your review 💪! Also have a look at the questions in the OP.
|
That backtracking is expected. It would be a good idea to pin any packages that pip's backtracking on, since that's happening due to conflicts somewhere in the graph. |
cheers, I guess the feedback would be that it might be ideal to have the option to not keep these packages in memory (or whatever is happening), but maybe this is just a niche case. @mbercx so yeh try creating the python environment locally (in a venv) using |
👌 Thanks @pradyunsg and @chrisjsewell! I'll look into fixing it asap. |
f934663
to
2a2985e
Compare
2a2985e
to
6a78f2b
Compare
@chrisjsewell I've updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second batch of comments. Overall nice work, the tutorial is coming out pretty nice @mbercx !
Co-authored-by: ramirezfranciscof <ramirezfranciscof@users.noreply.github.com>
First draft of the tutorial materials! This time in a PR that's a little easier to review 😅.
Questions/TODO
Should we add a note on why running takes so long (i.e. the use of a scheduler)?<PK>
and<UUID>
everywhere is a good idea in the end?Issue in #4063 fromAssigned myself so I remember to work on it at some point.aiida-core
still hasn't been fixed. 😅I've updated the images, but after building withSeems to be fixed nowmake html
, the old ones are still showing... 🤨 Let's see if this also happens here.wget
command is a bit much. 🤔➡️ Remaining questions copied to separate issue #286.