Bump aio pika to 8.1.8 #113
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #113 +/- ##
===========================================
- Coverage 90.32% 87.98% -2.33%
===========================================
Files 16 16
Lines 1146 1156 +10
===========================================
- Hits 1035 1017 -18
- Misses 111 139 +28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@muhrin could you have a look at these changes? A critical change I am not confident in is that since Also pinning @sphuber @chrisjsewell for comment. |
kiwipy/rmq/tasks.py
Outdated
| def _outcome_destroyed(self, outcome_ref): | ||
| # This only happens if someone called self.process() and then let the future | ||
| # get destroyed without setting an outcome | ||
| assert outcome_ref is self._outcome_ref | ||
| # This task will not be processed | ||
| self._outcome_ref = None | ||
| self.requeue() | ||
| self._subscriber.loop().create_task(self.requeue()) |
There was a problem hiding this comment.
Why does it call requeue() using create_task when requeue() itself uses the loop_scheduler to await? Shouldn't this just be a requeue() call?
| message_exchange = f'{__file__}.{shortuuid.uuid()}' | ||
| task_exchange = f'{__file__}.{shortuuid.uuid()}' | ||
| task_queue = f'{__file__}.{shortuuid.uuid()}' | ||
| message_exchange = f'{shortuuid.uuid()}' |
There was a problem hiding this comment.
Why did you remove the __file__ part? Sometimes, I found it useful to have the file in there so that when looking at the RMQ web console I could tell which test the queues/exchanges belong to.
There was a problem hiding this comment.
This is because pamqp will check the exchange channel name, special characters such as _.*/ are not allowed.
| message_exchange = f'{__file__}.{shortuuid.uuid()}' | ||
| task_exchange = f'{__file__}.{shortuuid.uuid()}' | ||
| task_queue = f'{__file__}.{shortuuid.uuid()}' | ||
| message_exchange = f'{shortuuid.uuid()}' |
There was a problem hiding this comment.
Similar to my comment above about __file__
|
Hi @muhrin, it's been so long that I think that probably better to set a quick meeting and check this together again. |
|
Superseded by #114 |
pamqpwill check the exchange channel name,_.*/are not allowed. Usinguuidonly.ackandnackwhich called whenrequeuetask are async function inaio-pika