Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1.2 Fix rebirth costs requiring a higher upfront cost #465

Merged
merged 2 commits into from
May 6, 2024

Conversation

TrustyJAID
Copy link
Collaborator

@TrustyJAID TrustyJAID commented May 6, 2024

  • Rebirth cost now has a fixed price of 1000*rebirths in addition to a percentage of the users balance if set.
  • Add --att and --attack aliases for cbackpack.
  • Fix cbackpack incorrectly filtering based on certain criteria.
    • Two handed weapons were not filtered based on their actual stat ranges
    • lvl filter was showing equip level not item level.

- Rebirth cost now has a fixed price of 1000*rebirths in addition to a percentage of the users balance if set.
- Add `--att` and `--attack` aliases for cbackpack.
- Fix cbackpack incorrectly filtering based on certain criteria.
 - Two handed weapons were not filtered based on their actual stat ranges
 - lvl filter was showing equip level not item level.
@aikaterna aikaterna merged commit 752e2a0 into aikaterna:master May 6, 2024
2 checks passed
@Smayxor
Copy link

Smayxor commented Jun 23, 2024

i was just wanting to check if line 2033 is correct
rebirths = c.rebirths * (3 if c.hc is not HeroClasses.berserker else 1)
all the other classes lines look like
rebirths = c.rebirths * (3 if c.hc is HeroClasses.wizard else 1)
notice on the berserker the usage of "not" in the boolean evaluation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants