Fix scope management issue when deep-inferring callee. #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #941. However, this currently breaks the stdlib somehow with some FreeUnique on the shrinker step of the optimizer.
KtorZ
force-pushed
the
fix/scope-when-backtracking
branch
from
de07396
to
eadf709
Compare
This is crucial as some checks regarding variable usages depends on warnings; so we may accidentally remove variables from the AST as a consequence of backtracking for deep inferrence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 Fix scope management issue when deep-inferring callee.
Fixes typecheck permitting variables not in (hygenic) scope #941.
However, this currently breaks the stdlib somehow with some FreeUnique on the shrinker step of the optimizer.
📍 Also preserve warnings when resetting scope for backtracking.
This is crucial as some checks regarding variable usages depends on
warnings; so we may accidentally remove variables from the AST as a
consequence of backtracking for deep inferrence.