Skip to content

Commit

Permalink
#332 Collect design discussions in MicroSite development section
Browse files Browse the repository at this point in the history
  • Loading branch information
ascheman committed Aug 15, 2024
1 parent b901699 commit 4e6eee7
Show file tree
Hide file tree
Showing 8 changed files with 20 additions and 7 deletions.
1 change: 1 addition & 0 deletions src/docs/development/_includes/.jbakeignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do not render these files directly
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ writing a new checker, especially should there be
no central _registry_ of checkers.

Up to v 1.0.0-RC-1 we violated the OCP and allowed
major redundancies in code:
major redundancies in the code:

[source,java]
----
Expand All @@ -33,8 +33,6 @@ class AllCheckers {
----




=== Solution Approach

A solution needs to address two issues:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ ifndef::plantumldir[:plantumldir: .plantuml/]

== Refactoring the Main Checking Loop


https://github.com/aim42/htmlSanityCheck/issues/190[Issue 190]
proposes to merge the two classes AllChecksRunner and ChecksRunner.

Expand All @@ -13,6 +12,3 @@ proposes to merge the two classes AllChecksRunner and ChecksRunner.
....
include::MainLoop-new.puml[]
....



File renamed without changes.
File renamed without changes.
File renamed without changes.
18 changes: 18 additions & 0 deletions src/docs/development/design-discussions.adoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
:filename: development/design-decisions.adoc
:jbake-title: Design Discussions
:jbake-type: page_toc
:jbake-status: published
:jbake-menu: development
:jbake-order: 20
== {jbake-title}
:icons: font
:toc: right
:toclevels: 3
:toc-position: right
// :experimental:

include::_includes/issue-185.adoc[leveloffset=+1]
include::_includes/issue-190.adoc[leveloffset=+1]
include::_includes/issue-219.adoc[leveloffset=+1]
include::_includes/issue-244.adoc[leveloffset=+1]
include::_includes/issue-252.adoc[leveloffset=+1]

0 comments on commit 4e6eee7

Please sign in to comment.