Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect further variants of (remote) URLs #29

Closed
gernotstarke opened this issue Sep 26, 2014 · 2 comments
Closed

detect further variants of (remote) URLs #29

gernotstarke opened this issue Sep 26, 2014 · 2 comments
Assignees
@gernotstarke

Comments

@gernotstarke
Copy link
Member

No description provided.

@gernotstarke gernotstarke added this to the 1.0.0 milestone Sep 26, 2014
@gernotstarke
Copy link
Member Author

There are many options for hostnames in href- or src-attributes:

  • www....
  • protocol://IP-Address/path
  • //IP-Address/path

the current checks in isRemoteURL in URLUtil.class is by no means complete and needs polishing...

@gernotstarke gernotstarke changed the title detect further variants of hostnames detect further variants of URLs Oct 29, 2014
@gernotstarke gernotstarke self-assigned this Oct 30, 2014
@gernotstarke gernotstarke modified the milestones: 0.8.0, 1.0.0 Dec 17, 2014
@gernotstarke gernotstarke changed the title detect further variants of URLs detect further variants of (remote) URLs Dec 26, 2014
@gernotstarke
Copy link
Member Author

currently, URLs of the following form are NOT recognized properly:

//10.0.0.1/index.html

this is currently identified as "isLocal" by URLUtil-class:

URLUtil.isLocalResource( link ) == isLocal
        |                |      |  |
        true             |      |  false
                         |      false
                         //10.0.0.1/index.html

@gernotstarke gernotstarke removed the bug label Dec 26, 2014
gernotstarke added a commit that referenced this issue Dec 27, 2014
@gernotstarke
Merge branch 'hotfix/#29-detect-further-variants-of-remote-URLs' into…
991abf9 
… develop

Conflicts:
	changelog.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gernotstarke gernotstarke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gernotstarke