Skip to content

Added TicTacToe to notebook #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 10, 2016
Merged

Added TicTacToe to notebook #213

merged 6 commits into from
Apr 10, 2016

Conversation

Chipe1
Copy link
Contributor

@Chipe1 Chipe1 commented Apr 10, 2016

You can now play TicTacToe with human, random or alphabeta player

@Chipe1
Copy link
Contributor Author

Chipe1 commented Apr 10, 2016

@norvig This PR overwrites #211 . So that PR needs to be reverted to resolve the conflict.

@norvig
Copy link
Collaborator

norvig commented Apr 10, 2016

@Chipe1 I'm not sure how to revert #211

@Chipe1
Copy link
Contributor Author

Chipe1 commented Apr 10, 2016

@reachtarunhere
Copy link
Collaborator

@Chipe1 @norvig I have a suggestion. We should move the canvas.js file to the js directory so as to keep things organized. So before this is merged maybe @Chipe1 can make the required changes.

@SnShine
Copy link
Collaborator

SnShine commented Apr 10, 2016

Need some inputs here. Which name would be nice for the interactive game Interactive_TicTacToe or Canvas_TicTacToe?
Right now, we are having js files in js folder as mentioned by @reachtarunhere. It would be better if we move js files to this folder.
And, would it be nice to have ipyviews.py and canvas.py in the same file?

And @norvig reverting a PR is easy but it creates one more PR while reverting. It would be better if @Chipe1 can rebase/merge this branch with updated master branch and push a new commit to resolve conflicts.

@reachtarunhere
Copy link
Collaborator

@SnShine I like the idea of having content of canvas and and ipyviews together in ipyviews. But the issue is that I am not sure how well the canvas file follows the model view architecture. Overall it would be a good idea to have them together. I am also writing a ipynotebook for ipyviews explaining the usage. Probably @Chipe1 can then add to it and we can have a good doc on how to use his general canvas implementation.

@Chipe1
Copy link
Contributor Author

Chipe1 commented Apr 10, 2016

I fixed the conflict and moved canvas.js to js folder

@norvig norvig merged commit d291e0a into aimacode:master Apr 10, 2016
@Chipe1 Chipe1 deleted the search branch May 18, 2016 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants