Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: boostings related failure of test_*_models_check_fit_predict_correct #1316

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Lopa10ko
Copy link
Collaborator

@Lopa10ko Lopa10ko commented Aug 1, 2024

This is a 🐛 bug fix.

Summary

  • Add a temporary check for intentional target substitutions when converting to a dataframe (94b12c3)

Context

fixes failed integration test runs:

@Lopa10ko Lopa10ko self-assigned this Aug 1, 2024
@Lopa10ko Lopa10ko requested a review from aPovidlo August 1, 2024 13:29
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Code has no PEP8 errors!

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.14%. Comparing base (0368e9c) to head (94b12c3).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...mplementations/models/boostings_implementations.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1316      +/-   ##
==========================================
- Coverage   80.17%   80.14%   -0.04%     
==========================================
  Files         146      146              
  Lines       10274    10278       +4     
==========================================
  Hits         8237     8237              
- Misses       2037     2041       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aPovidlo aPovidlo self-requested a review August 1, 2024 13:41
@Lopa10ko Lopa10ko merged commit 3d49382 into master Aug 1, 2024
10 checks passed
@Lopa10ko Lopa10ko deleted the hotfix-integration-boostings branch August 1, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants