Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: pin nltk version to avoid downloading punkt_tab #1321

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

Lopa10ko
Copy link
Collaborator

This is a 🐛 bug fix.

Summary

  • remove punkt_tab from lookup list when downloading nltk resources (20a6d88)
  • pin nltk version to stable 3.8.1 (c75c43)

Context

related to nltk/nltk#3293

@Lopa10ko Lopa10ko self-assigned this Aug 15, 2024
Copy link
Contributor

Code has no PEP8 errors!

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.16%. Comparing base (39e960c) to head (20a6d88).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
...lementations/data_operations/text_preprocessing.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1321   +/-   ##
=======================================
  Coverage   80.16%   80.16%           
=======================================
  Files         146      146           
  Lines       10278    10278           
=======================================
  Hits         8239     8239           
  Misses       2039     2039           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lopa10ko
Copy link
Collaborator Author

Copy link
Collaborator

@DRMPN DRMPN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Lopa10ko Lopa10ko merged commit 19f95f3 into master Aug 16, 2024
13 of 16 checks passed
@Lopa10ko Lopa10ko deleted the hotfix-pin-nltk branch August 16, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants