Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase timer & decrease num of generations for quality integration test #1349

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

DRMPN
Copy link
Collaborator

@DRMPN DRMPN commented Nov 15, 2024

This is a 🐛 bug fix.

Summary

  • Increases time for composition from 4 to 10 minutes
  • Decreases number of generations from 10 to 1

pop_size doesn't affect the runtime as much as num_of_generations.

Test runtime measurements:

  1. num_of_generations = 1, execution = 4.5+ minutes
  2. num_of_generations = 2, execution = 8.5+ minutes
  3. num_of_generations = 3, execution = 12.5+ minutes
  4. num_of_generations = 4, execution = 16.5+ minutes

Context

The time limit for running tests on GitHub.

@DRMPN DRMPN added the test The additon or modification of the unit test label Nov 15, 2024
@DRMPN DRMPN self-assigned this Nov 15, 2024
Copy link
Contributor

github-actions bot commented Nov 15, 2024

All PEP8 errors has been fixed, thanks ❤️

Comment last updated at Fri, 15 Nov 2024 20:18:24

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.33%. Comparing base (1bd63c2) to head (a8eac10).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1349   +/-   ##
=======================================
  Coverage   80.33%   80.33%           
=======================================
  Files         146      146           
  Lines       10464    10464           
=======================================
  Hits         8406     8406           
  Misses       2058     2058           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DRMPN DRMPN merged commit b0618df into master Nov 15, 2024
7 checks passed
@nicl-nno nicl-nno deleted the DRMPN-quick-fix-quality-integration-test branch November 18, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test The additon or modification of the unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants