Encodings for graphs #129
Merged
Encodings for graphs #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_drop_mutation-fails-to-remove-node
maypink
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 72.22% 72.45% +0.22%
==========================================
Files 127 128 +1
Lines 7284 7377 +93
==========================================
+ Hits 5261 5345 +84
- Misses 2023 2032 +9
|
gkirgizov
requested changes
Jun 26, 2023
| for graph in initial_graphs: | ||
| opt_graph = BaseNetworkxAdapter().adapt(item=graph) | ||
| for node in opt_graph.nodes: | ||
| node.content['name'] = 'x' |
There was a problem hiding this comment.
Вот, кажется, такие штуки тяжело будет ловить, тяжело избегать и невозможно запретить при учете изменений с кэшированием descriptive_id
There was a problem hiding this comment.
как вариант -- добавить флаг в descriptive_id, чтобы его можно было пересчитать принудительно. ну и оставить там предупреждение о такого рода действиях
здесь так сделано из-за того, что при адаптации в имена нод ставится их uid
запускала на синтетическом примере, но скорее для проверки работоспособности, а не сравнения полученных метрик |
gkirgizov
approved these changes
Jul 5, 2023
maypink
force-pushed
the
124-add-various-encodings-for-graphs
branch
from
e844604 to
6cb4ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encodings for graphs with the use of nodes labels were added.