-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add molecule encodings for contextual bandit #179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @YamLyubov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-09-05 12:37:59 UTC |
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 74.02% 74.12% +0.10%
==========================================
Files 129 129
Lines 7688 7688
==========================================
+ Hits 5691 5699 +8
+ Misses 1997 1989 -8
|
YamLyubov
force-pushed
the
molecule-encoding
branch
from
September 1, 2023 09:21
a2c9193
to
7677098
Compare
maypink
requested changes
Sep 4, 2023
YamLyubov
force-pushed
the
molecule-encoding
branch
from
September 5, 2023 12:33
9436581
to
767f0f1
Compare
maypink
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds molecular encoders for contextual graphs.
Implemented approaches:
ECPF
- Extended-Connectivity Fingerprints -https://www.semanticscholar.org/paper/Extended-Connectivity-Fingerprints-Rogers-Hahn/d1b796ff0c1895426de11a1eaafc5443be29645d
RDKF
- RDKit topological fingerprint -https://www.rdkit.org/docs/GettingStartedInPython.html#rdkit-topological-fingerprints
atom_pair
- atom pair fingerprint - https://pubs.acs.org/doi/10.1021/ci00046a002topoligical_torsion
- topoligical torsion fingerprint - https://pubs.acs.org/doi/10.1021/ci00054a008mol_descriptors
- molecular descriptors -https://www.semanticscholar.org/paper/Molecular-representation-learning-with-language-and-Fabian-Edlich/e4c5e81e6e337bb94af3eb719df5f029b40434fa
Mol2Vec
- vector representations (pretrained model) -https://pubs.acs.org/doi/10.1021/acs.jcim.7b00616
MoleculeTransformer
- vector representation (pretrained model) -https://pdfs.semanticscholar.org/2b80/1b911a5a33a4fe523b667c5f6b1b8bbadbbf.pdf
Collected materials: https://docs.google.com/spreadsheets/d/1qDx6hhRMeA185_fLxBRwwcHHmvUOxbG9ID_IkOYZV-g/edit?usp=sharing
Results for 10 trials:
qed score
normalized sa score
#176