Fix crossover #212
Merged
Fix crossover #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @YamLyubov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-10-10 12:07:12 UTC |
Codecov Report
@@ Coverage Diff @@
## main #212 +/- ##
==========================================
- Coverage 73.76% 73.76% -0.01%
==========================================
Files 131 131
Lines 7826 7833 +7
==========================================
+ Hits 5773 5778 +5
- Misses 2053 2055 +2
|
maypink
requested changes
Oct 10, 2023
| @@ -0,0 +1,57 @@ | |||
| from functools import partial | |||
There was a problem hiding this comment.
в названии файла потерялось нижнее подчеркивание))
| ) | ||
|
|
||
| # Generate simple initial population with cyclic graphs | ||
| initial_graphs = [generate_labeled_graph('tree', i) for i in range(4, 20)] |
There was a problem hiding this comment.
сюда наверно тоже надо прокинуть graph_type, а не tree по дефолту
test/unit/adapter/test_adapter.py
Outdated
| @@ -34,7 +34,8 @@ def test_adapters_params_correct(adapter, graph_with_params): | |||
| if isinstance(graph, Graph): | |||
| restored_alpha = restored_graph.root_node.content['params']['alpha'] | |||
| else: | |||
| restored_alpha = restored_graph.nodes['c']['alpha'] | |||
| root_node = [node for node, data in restored_graph.nodes(data='alpha', default=None) if data is not None][0] | |||
There was a problem hiding this comment.
почему просто не взять ноду с тем же индексом? судя по всему, в нетворксе они также идут в порядке обхода в глубину
There was a problem hiding this comment.
Сделал немного читаемее
maypink
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
structural_equivalent_nodesAdds test for evolution with crossover.
#206