-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add b+ tree secondary indexing for fast search and retrieval #22
Open
bkal01
wants to merge
20
commits into
aimhubio:develop
Choose a base branch
from
bkal01:feature/bplustree
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds a secondary indexing option using a B+ tree closely mirroring the existing primary indexing option. I added
Node
andBPlusTree
classes for the tree structure and included testing. I also added asecondary_indexing
option when adding/reading records. For example, if the user wants to index by 'val', they passsecondary_indexing={'val': val}
into the append_record method. The tree is saved in.aimrecords_storage/<insert_artifact_name>/val.tree
and can be loaded/saved using pickle.There are issues with consecutive runs of the secondary_indexing_example. For example, if we save 1000 records with val=1,2,...,1000 and then run the example again, There are 2000 records remembered but still only 1000 keys for the 1000 new records. This causes some issues when trying to access records using negative indexing