Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Pub/Sub Receiver stop() fix #211

Merged
merged 2 commits into from
Apr 28, 2017
Merged

Pub/Sub Receiver stop() fix #211

merged 2 commits into from
Apr 28, 2017

Conversation

popravich
Copy link
Contributor

This fixes the case when pubsub receiver is blocked in get() and then stop() is called,
see test for details.

@codecov-io
Copy link

codecov-io commented Apr 28, 2017

Codecov Report

Merging #211 into master will decrease coverage by 0.08%.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage    95.6%   95.51%   -0.09%     
==========================================
  Files          56       56              
  Lines        7273     7286      +13     
  Branches      595      596       +1     
==========================================
+ Hits         6953     6959       +6     
- Misses        231      237       +6     
- Partials       89       90       +1
Impacted Files Coverage Δ
tests/py35_pubsub_receiver_test.py 85.71% <70.58%> (-14.29%) ⬇️
aioredis/commands/transaction.py 84.72% <0%> (-1.39%) ⬇️
tests/sentinel_failover_test.py 86.46% <0%> (ø) ⬆️
aioredis/sentinel/pool.py 82.1% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4496497...ac37dbe. Read the comment docs.

@popravich popravich merged commit bae300b into master Apr 28, 2017
@popravich popravich deleted the pubsub_receiver_stop_fix branch April 28, 2017 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants