This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
Add encoding option to sorted set #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshilliard
force-pushed
the
encoding-options
branch
2 times, most recently
from
db6971f
to
78b63d4
Compare
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
==========================================
- Coverage 96.78% 96.77% -0.02%
==========================================
Files 55 55
Lines 7747 7778 +31
Branches 615 621 +6
==========================================
+ Hits 7498 7527 +29
Misses 181 181
- Partials 68 70 +2
Continue to review full report at Codecov.
|
|
Please, add tests for the case when encoding is specified. |
jameshilliard
force-pushed
the
encoding-options
branch
2 times, most recently
from
c01f2e1
to
2743adb
Compare
jameshilliard
force-pushed
the
encoding-options
branch
from
2743adb
to
ce5de0f
Compare
|
I've added tests, AppVeyor seems to not be picking up my changes in this PR although tests pass here. |
popravich
approved these changes
Nov 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this option is missing for sorted sets.