Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

few fixes related to uvloop #347

Merged
merged 3 commits into from
Dec 5, 2017
Merged

few fixes related to uvloop #347

merged 3 commits into from
Dec 5, 2017

Conversation

popravich
Copy link
Contributor

  • Fix "max clients" tests — uvloop closes connection earlier and so ConnectionClosedError is raised;
  • Fix aioredis.StreamReader to buffer data until set_parser is called — uvloop reads and calls feed_data earlier than asyncio loop.

@codecov
Copy link

codecov bot commented Dec 1, 2017

Codecov Report

Merging #347 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
+ Coverage   96.77%   96.83%   +0.06%     
==========================================
  Files          55       54       -1     
  Lines        7807     7309     -498     
  Branches      622      519     -103     
==========================================
- Hits         7555     7078     -477     
+ Misses        183      167      -16     
+ Partials       69       64       -5
Impacted Files Coverage Δ
tests/conftest.py 88.57% <ø> (+0.12%) ⬆️
tests/pool_test.py 99.67% <100%> (ø) ⬆️
tests/connection_test.py 100% <100%> (ø) ⬆️
aioredis/stream.py 92.15% <100%> (+1.45%) ⬆️
aioredis/sentinel/pool.py 79.46% <0%> (-6.76%) ⬇️
tests/sentinel_failover_test.py 86.46% <0%> (-1.51%) ⬇️
aioredis/sentinel/__init__.py 100% <0%> (ø) ⬆️
examples/connection.py
aioredis/commands/pubsub.py 100% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 422605e...b612b86. Read the comment docs.

@popravich popravich merged commit 5f44b2a into master Dec 5, 2017
@popravich popravich deleted the uvloop_fixes branch December 5, 2017 20:31
@popravich popravich added this to the v1.1 milestone Feb 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant