Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Fixed ConnectionsPool.[pubsub_channels/pubsub_patterns] #351

Closed
wants to merge 1 commit into from

Conversation

frostoov
Copy link

@frostoov frostoov commented Dec 7, 2017

Fixed bug in commands.pubsub.PubSubCommandsMixin.subscribe (and psubscribe). ConnectionsPool.pubsub_channles code was called before ConnectionsPool._pubsub_conn creation, and therefore pubsub_channles

@frostoov frostoov closed this Dec 7, 2017
@frostoov frostoov reopened this Dec 7, 2017
@codecov
Copy link

codecov bot commented Dec 7, 2017

Codecov Report

Merging #351 into master will decrease coverage by 0.02%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   96.86%   96.84%   -0.03%     
==========================================
  Files          54       54              
  Lines        7309     7319      +10     
  Branches      519      519              
==========================================
+ Hits         7080     7088       +8     
- Misses        168      169       +1     
- Partials       61       62       +1
Impacted Files Coverage Δ
aioredis/util.py 94.07% <80%> (-1.13%) ⬇️
tests/sentinel_failover_test.py 86.46% <0%> (-1.51%) ⬇️
aioredis/sentinel/pool.py 80.22% <0%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f44b2a...ea6d5da. Read the comment docs.

@frostoov frostoov changed the title fixed ConnectionsPool.[pubsub_channels/pubsub_patterns] Fixed ConnectionsPool.[pubsub_channels/pubsub_patterns] Dec 8, 2017
@popravich popravich closed this in 34b26c6 Dec 14, 2017
popravich added a commit that referenced this pull request Dec 14, 2017
fix issue with subscribe/psubscribe with empty pool (fixes #351)
@popravich
Copy link
Contributor

Thanks for the report.
I've pushed a bit simpler patch.

@popravich popravich added the bug label Dec 14, 2017
@frostoov frostoov deleted the pubsub_channels branch December 14, 2017 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants