Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

checking if reader is None #447

Closed

Conversation

khudyakovavi
Copy link

Getting errors when connection was closed:

  File "/usr/local/lib/python3.6/site-packages/tornado/gen.py", line 1069, in run
    yielded = self.gen.send(value)
  File "<string>", line 6, in _wrap_awaitable
  File "/usr/local/lib/python3.6/site-packages/cian_core/context/_stack_context.py", line 70, in wrapper
    val = yielded.send(res)
  File "/usr/local/lib/python3.6/site-packages/aioredis/connection.py", line 199, in _read_data
    if (obj == b'' or obj is None) and self._reader.at_eof():
AttributeError: 'NoneType' object has no attribute 'at_eof'

Copy link
Contributor

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you also add a test for that?

@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

Merging #447 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #447      +/-   ##
=========================================
- Coverage   96.85%   96.8%   -0.06%     
=========================================
  Files          56      56              
  Lines        7831    7831              
  Branches      548     548              
=========================================
- Hits         7585    7581       -4     
- Misses        177     180       +3     
- Partials       69      70       +1
Impacted Files Coverage Δ
aioredis/sentinel/pool.py 80.82% <0%> (-1.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea948d0...3721dd3. Read the comment docs.

@seandstewart
Copy link
Collaborator

This change has been superseded by #891.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants