Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform metadata validation in CI/CD workflow #1164

Closed
jakob-keller opened this issue Aug 21, 2024 · 0 comments · Fixed by #1163
Closed

Perform metadata validation in CI/CD workflow #1164

jakob-keller opened this issue Aug 21, 2024 · 0 comments · Fixed by #1163
Assignees
@jakob-keller
Labels
github_actions Pull requests that update GitHub Actions code

Comments

@jakob-keller
Copy link
Collaborator 

          I recommend running dist build unconditionally, at the very beginning of the workflow + running `twine check --strict`. It's not pleasant when the metadata validation fails at the last moment when releasing.

Besides, it'd provide a good indicator of the ability to build it continuously.
I personally even run tests against those. But this is something that could be explored in a follow-up.

Originally posted by @webknjaz in #1158 (comment)
@jakob-keller jakob-keller added the github_actions Pull requests that update GitHub Actions code label Aug 21, 2024
@jakob-keller jakob-keller mentioned this issue Aug 21, 2024
Merged
13 tasks
jakob-keller added a commit to jakob-keller/aiobotocore that referenced this issue Aug 21, 2024
@jakob-keller
build distribution unconditionally and perform metadata validation in…
a4f32b1 
… CI/CD workflow (aio-libs#1164)
@jakob-keller jakob-keller mentioned this issue Aug 21, 2024
Merged
13 tasks
@jakob-keller jakob-keller self-assigned this Aug 21, 2024
jakob-keller added a commit to jakob-keller/aiobotocore that referenced this issue Aug 21, 2024
@jakob-keller
modernize CI/CD workflow (aio-libs#1164)
16209f8
jakob-keller added a commit to jakob-keller/aiobotocore that referenced this issue Aug 21, 2024
@jakob-keller
modernize CI/CD workflow (aio-libs#1164)
64e5e80
jakob-keller added a commit to jakob-keller/aiobotocore that referenced this issue Aug 21, 2024
@jakob-keller
modernize CI/CD workflow (aio-libs#1164)
3853656
jakob-keller added a commit to jakob-keller/aiobotocore that referenced this issue Aug 22, 2024
@jakob-keller
modernize CI/CD workflow (aio-libs#1164)
7782cc2
jakob-keller added a commit to jakob-keller/aiobotocore that referenced this issue Aug 22, 2024
@jakob-keller
modernize CI/CD workflow (aio-libs#1164)
1f12379
jakob-keller added a commit to jakob-keller/aiobotocore that referenced this issue Aug 22, 2024
@jakob-keller
modernize CI/CD workflow (aio-libs#1164)
de04f7b
chemelli74 pushed a commit to chemelli74/aiobotocore that referenced this issue Aug 29, 2024
@jakob-keller @chemelli74
modernize CI/CD workflow (aio-libs#1164)
e38d68b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakob-keller jakob-keller

Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modernize CI/CD workflow jakob-keller/aiobotocore
1 participant
@jakob-keller