Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address breaking change introduced in aiohttp==3.9.2 #1081

Merged
merged 3 commits into from
May 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
include:
- aiohttp-version: '==3.7.4.post0'
- aiohttp-version: '==3.9.2'
- aiohttp-version: '<4.0.0'
python-version: '3.11'
fail-fast: false
Expand Down
4 changes: 4 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
Changes
-------

2.13.0 (2024-05-16)
^^^^^^^^^^^^^^^^^^^
* address breaking change introduced in `aiohttp==3.9.2` #882

2.12.4 (2024-05-16)
^^^^^^^^^^^^^^^^^^^
* bump botocore dependency specification
Expand Down
2 changes: 1 addition & 1 deletion aiobotocore/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '2.12.4'
__version__ = '2.13.0'
3 changes: 1 addition & 2 deletions aiobotocore/httpsession.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,7 @@ def _create_connector(self, proxy_url):

return aiohttp.TCPConnector(
limit=self._max_pool_connections,
verify_ssl=bool(self._verify),
ssl=ssl_context,
ssl=ssl_context or False,
**self._connector_args,
)

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
install_requires = [
# pegged to also match items in `extras_require`
'botocore>=1.34.70,<1.34.107',
'aiohttp>=3.7.4.post0,<4.0.0',
jakob-keller marked this conversation as resolved.
Show resolved Hide resolved
'aiohttp>=3.9.2,<4.0.0',
'wrapt>=1.10.10, <2.0.0',
'aioitertools>=0.5.1,<1.0.0',
]
Expand Down
2 changes: 1 addition & 1 deletion tests/test_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def test_release_versions():
rst_prev_date = datetime.strptime(rst_prev_date, '%Y-%m-%d').date()

assert (
rst_date > rst_prev_date
rst_date >= rst_prev_date
), 'Current release must be after last release'

# get aioboto reqs
Expand Down
Loading