Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecated use of aiohttp in tests #1139

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Replace deprecated aiohttp session.get() argument verify_ssl by ssl in tests. This should have been part of #1081.

Assumptions

None

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the bug Something isn't working label Aug 17, 2024
@jakob-keller jakob-keller self-assigned this Aug 17, 2024
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@44f279e). Learn more about missing BASE report.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1139   +/-   ##
=========================================
  Coverage          ?   86.16%           
=========================================
  Files             ?       62           
  Lines             ?     5933           
  Branches          ?        0           
=========================================
  Hits              ?     5112           
  Misses            ?      821           
  Partials          ?        0           
Flag Coverage Δ
unittests 86.16% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller merged commit 54a110b into aio-libs:master Aug 17, 2024
8 checks passed
@jakob-keller jakob-keller deleted the fix-ssl-in-tests branch August 17, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant