Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix refreshable credentials injection #1314

Merged
merged 6 commits into from
Mar 4, 2025

Conversation

thehesiod
Copy link
Collaborator

fixes issue #1313

@thehesiod thehesiod requested a review from jakob-keller March 4, 2025 06:57
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 90.53%. Comparing base (1515727) to head (3ee8285).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
aiobotocore/credentials.py 45.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1314      +/-   ##
==========================================
- Coverage   90.76%   90.53%   -0.23%     
==========================================
  Files          68       68              
  Lines        6542     6564      +22     
==========================================
+ Hits         5938     5943       +5     
- Misses        604      621      +17     
Flag Coverage Δ
unittests 90.53% <56.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehesiod
Copy link
Collaborator Author

the base class impls may never get called, just there for correctness

@thehesiod thehesiod changed the title thehesiod/fix-refreshable-credentials fix refreshable credentials injection Mar 4, 2025
Copy link
Collaborator

@jakob-keller jakob-keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean. Thanks for the fix!

@thehesiod thehesiod enabled auto-merge March 4, 2025 08:52
@thehesiod thehesiod disabled auto-merge March 4, 2025 08:52
@thehesiod thehesiod merged commit d145aea into master Mar 4, 2025
19 of 20 checks passed
@thehesiod thehesiod deleted the thehesiod/fix-refreshable-credentials branch March 4, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants