Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend and improve usage of Cache class #446

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

argaen
Copy link
Member

@argaen argaen commented Mar 7, 2019

Trying to push usage of Cache.MEMORY accessor like instead of accessing the constructor directly

def __init__(self, serializer=None, **kwargs):
super().__init__(**kwargs)
self.serializer = serializer or JsonSerializer()

@classmethod
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from before, not sure why I did put the method in the backend class but backend should contain methods only related to the client implementation and this is not

@argaen argaen force-pushed the improve_new_Cache_integration branch from 9e0b8c0 to 440b499 Compare March 8, 2019 10:48
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #446 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   99.57%   99.57%   +<.01%     
==========================================
  Files          11       11              
  Lines         931      941      +10     
  Branches      101      101              
==========================================
+ Hits          927      937      +10     
  Misses          4        4
Impacted Files Coverage Δ
aiocache/serializers/serializers.py 96.55% <ø> (ø) ⬆️
aiocache/backends/memcached.py 100% <100%> (ø) ⬆️
aiocache/backends/memory.py 100% <100%> (ø) ⬆️
aiocache/decorators.py 100% <100%> (ø) ⬆️
aiocache/factory.py 100% <100%> (ø) ⬆️
aiocache/backends/redis.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc65b3b...440b499. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #446 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   99.57%   99.57%   +<.01%     
==========================================
  Files          11       11              
  Lines         931      941      +10     
  Branches      101      101              
==========================================
+ Hits          927      937      +10     
  Misses          4        4
Impacted Files Coverage Δ
aiocache/serializers/serializers.py 96.55% <ø> (ø) ⬆️
aiocache/backends/memcached.py 100% <100%> (ø) ⬆️
aiocache/backends/memory.py 100% <100%> (ø) ⬆️
aiocache/decorators.py 100% <100%> (ø) ⬆️
aiocache/factory.py 100% <100%> (ø) ⬆️
aiocache/backends/redis.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc65b3b...440b499. Read the comment docs.

@argaen argaen merged commit 0698823 into master Mar 8, 2019
@argaen argaen deleted the improve_new_Cache_integration branch March 8, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant