Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loop pickling #154

Merged
merged 4 commits into from
Oct 19, 2017
Merged

loop pickling #154

merged 4 commits into from
Oct 19, 2017

Conversation

samuelcolvin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 19, 2017

Codecov Report

Merging #154 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #154      +/-   ##
=========================================
+ Coverage   94.88%   94.9%   +0.02%     
=========================================
  Files          13      13              
  Lines         762     766       +4     
  Branches       93      93              
=========================================
+ Hits          723     727       +4     
  Misses         25      25              
  Partials       14      14
Impacted Files Coverage Δ
aiohttp_devtools/runserver/watch.py 94.44% <100%> (ø) ⬆️
aiohttp_devtools/runserver/main.py 100% <100%> (ø) ⬆️
aiohttp_devtools/runserver/config.py 88.28% <100%> (+0.18%) ⬆️
aiohttp_devtools/runserver/serve.py 94.29% <100%> (+0.05%) ⬆️
aiohttp_devtools/version.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a570e8...19aeaed. Read the comment docs.

@samuelcolvin
Copy link
Member Author

ok, this is my final attempt. If there are still occasional exceptions when shutting down runserver, that's just how it is. Happy to accept PRs to improve it.

@achernetsky
Copy link

@samuelcolvin, ok, thanks for you attempts!

@samuelcolvin samuelcolvin merged commit 62ee8b2 into master Oct 19, 2017
@samuelcolvin samuelcolvin deleted the loop-fix branch October 19, 2017 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants