Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert to multiprocessing reload #188

Merged
merged 7 commits into from
May 29, 2018
Merged

revert to multiprocessing reload #188

merged 7 commits into from
May 29, 2018

Conversation

samuelcolvin
Copy link
Member

fix #186

I too had problems with reload not working properly, I think sadly the only reliable solution is to use multiprocessing.

@codecov
Copy link

codecov bot commented May 26, 2018

Codecov Report

Merging #188 into master will decrease coverage by 0.54%.
The diff coverage is 87.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage    94.8%   94.26%   -0.55%     
==========================================
  Files          12       12              
  Lines         732      750      +18     
  Branches       97       94       -3     
==========================================
+ Hits          694      707      +13     
- Misses         23       28       +5     
  Partials       15       15
Impacted Files Coverage Δ
aiohttp_devtools/runserver/main.py 100% <100%> (ø) ⬆️
aiohttp_devtools/runserver/serve.py 94.19% <100%> (+0.29%) ⬆️
aiohttp_devtools/runserver/config.py 86.48% <66.66%> (-2.24%) ⬇️
aiohttp_devtools/runserver/watch.py 91.08% <87.5%> (-3.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d2451...39035b8. Read the comment docs.

@samuelcolvin samuelcolvin merged commit 7bb4c30 into master May 29, 2018
@samuelcolvin samuelcolvin deleted the multiprocess-reload branch May 29, 2018 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optional multiprocessing for reload
1 participant