Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import module order issue #652

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

venu
Copy link
Contributor

@venu venu commented Feb 13, 2024

What do these changes do?

If you have a package with same module name, adev tries to import the module from that package rather than honoring the project root.

This PR fixes this issue

Related issue number #651

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@venu venu changed the title Bugfix/import order issue Fix import module order issue Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07d2ae6) 91.20% compared to head (15e0344) 91.68%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   91.20%   91.68%   +0.48%     
==========================================
  Files          12       12              
  Lines         830      830              
  Branches      143      143              
==========================================
+ Hits          757      761       +4     
+ Misses         47       44       -3     
+ Partials       26       25       -1     
Flag Coverage Δ
unit 91.56% <100.00%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer
Copy link
Member

Thanks

@Dreamsorcerer Dreamsorcerer merged commit 316488d into aio-libs:master Feb 16, 2024
21 checks passed
@venu venu deleted the bugfix/import_order_issue branch February 17, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants