Merge pull request #493 from morgan-del/url-parsing-bug

Fix #489 : properly parse URL's path

aiohttp/web_reqrep.py

@@ -173,7 +173,8 @@ def path_qs(self):
 
     @reify
     def _splitted_path(self):
-        return urlsplit(self._path_qs)
+        url = '{}://{}{}'.format(self.scheme, self.host, self._path_qs)
+        return urlsplit(url)
 
     @property
     def raw_path(self):

tests/test_web.py

@@ -16,6 +16,7 @@ def setUp(self):
     def tearDown(self):
         self.loop.close()
 
+    @unittest.skip('moved to test_web_functional')
     def test_handler_returns_not_response(self):
         app = web.Application(loop=self.loop)
 

tests/test_web_functional.py

@@ -66,6 +66,20 @@ def go():
 
         self.loop.run_until_complete(go())
 
+    def test_handler_returns_not_response(self):
+
+        @asyncio.coroutine
+        def handler(request):
+            return 'abc'
+
+        @asyncio.coroutine
+        def go():
+            _, _, url = yield from self.create_server('GET', '/', handler)
+            resp = yield from request('GET', url, loop=self.loop)
+            self.assertEqual(500, resp.status)
+
+        self.loop.run_until_complete(go())
+
     def test_post_form(self):
 
         @asyncio.coroutine

tests/test_web_request.py

@@ -64,6 +64,10 @@ def test_ctor(self):
         self.assertIs(self.transport, req.transport)
         self.assertTrue(req.keep_alive)
 
+    def test_doubleslashes(self):
+        req = self.make_request('GET', '//foo/')
+        self.assertEqual('//foo/', req.path)
+
     def test_POST(self):
         req = self.make_request('POST', '/')
         with self.assertRaises(RuntimeError):