Fix GunicornWebWorker max_requests_jitter

aio-libs · Aug 12, 2023 · 1797a28 · 1797a28
1 parent e481c05
commit 1797a28
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CHANGES/7518.bugfix b/CHANGES/7518.bugfix
@@ -0,0 +1 @@
+Fix GunicornWebWorker max_requests_jitter not work
diff --git a/aiohttp/worker.py b/aiohttp/worker.py
@@ -110,7 +110,7 @@ async def _run(self) -> None:
                 self.notify()
 
                 cnt = server.requests_count
-                if self.cfg.max_requests and cnt > self.cfg.max_requests:
+                if self.max_requests and cnt > self.max_requests:
                     self.alive = False
                     self.log.info("Max requests, shutting down: %s", self)
 

diff --git a/tests/test_worker.py b/tests/test_worker.py
@@ -214,8 +214,8 @@ async def test__run_ok_parent_changed(
     worker.sockets = [sock]
     worker.log = mock.Mock()
     worker.loop = loop
+    worker.max_requests = 0
     worker.cfg.access_log_format = ACCEPTABLE_LOG_FORMAT
-    worker.cfg.max_requests = 0
     worker.cfg.is_ssl = False
 
     await worker._run()
@@ -237,8 +237,8 @@ async def test__run_exc(
     worker.sockets = [sock]
     worker.log = mock.Mock()
     worker.loop = loop
+    worker.max_requests = 0
     worker.cfg.access_log_format = ACCEPTABLE_LOG_FORMAT
-    worker.cfg.max_requests = 0
     worker.cfg.is_ssl = False
 
     def raiser() -> None:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix GunicornWebWorker max_requests_jitter not work