Close unclosed client sessions properly (#2523)

* Close unclosed client sessions properly * Add news fragment * Drop it all together
aio-libs · Nov 17, 2017 · a40f63f · a40f63f
1 parent 50da0d7
commit a40f63f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/CHANGES/2523.bugfix b/CHANGES/2523.bugfix
@@ -0,0 +1 @@
+Fix warning in `ClientSession.__del__` by stopping to try to close it.
diff --git a/aiohttp/client.py b/aiohttp/client.py
@@ -126,8 +126,6 @@ def __init__(self, *, connector=None, loop=None, cookies=None,
 
     def __del__(self, _warnings=warnings):
         if not self.closed:
-            self.close()
-
             _warnings.warn("Unclosed client session {!r}".format(self),
                            ResourceWarning)
             context = {'client_session': self,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix warning in `ClientSession.__del__` by stopping to try to close it.