Fix #1866: Applications comparison is correct now (#1888)

aio-libs · May 14, 2017 · a40fb59 · a40fb59
1 parent 127c451
commit a40fb59
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -43,6 +43,8 @@ Changes
 
 - Fix sub-application middlewares resolution order #1853
 
+- Fix applications comparison #1866
+
 
 2.0.7 (2017-04-12)
 ------------------

diff --git a/aiohttp/web.py b/aiohttp/web.py
@@ -81,6 +81,9 @@ def __init__(self, *,
 
     # MutableMapping API
 
+    def __eq__(self, other):
+        return self is other
+
     def __getitem__(self, key):
         return self._state[key]
 

diff --git a/tests/test_web_application.py b/tests/test_web_application.py
@@ -219,3 +219,11 @@ def test_secure_proxy_ssl_header_init(loop):
     assert app._secure_proxy_ssl_header is hdr
     app.make_handler(loop=loop)
     assert app._secure_proxy_ssl_header is hdr
+
+
+def test_equality():
+    app1 = web.Application()
+    app2 = web.Application()
+
+    assert app1 == app1
+    assert app1 != app2