Skip to content

Commit

Permalink
Small cleanup to wss/ws fix
Browse files Browse the repository at this point in the history
followup to #8482
  • Loading branch information
bdraco committed Jul 17, 2024
1 parent 3fbb093 commit d4e608e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGES/8481.bugfix.rst
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
Fixed the incorrect rejection of ``ws://`` and ``wss://`` urls
when creating requests. This was a regression introduced in
#6722.
-- by :user:` AraHaan`.
2 changes: 1 addition & 1 deletion tests/test_client_session.py
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ async def create_connection(req, traces, timeout):
# if the connection wasn't already closed
for c in connections:
c.close()
del c
c.__del__()

Check warning

Code scanning / CodeQL

`__del__` is called explicitly Warning test

The __del__ special method is called explicitly.

await session.close()

Expand Down

0 comments on commit d4e608e

Please sign in to comment.