[QUESTION] WebSocketResponse timeout parameter

[Marco-Sulla]

WebSocketResponse timeout parameter is not documented:
https://aiohttp.readthedocs.io/en/stable/web_reference.html#websocketresponse

What does it do? It's a timeout for websocket creation or for websocket messages? From source code, it seems it involves websocket closing only.

[asvetlov]

You've raised very interesting and important question.
Yes, timeout should be enforced on all websocket operations.
Maybe 10 secs is too low value.
Documentation should be updated also to encourage sending pings (either WS PING frames or custom data packets).
It may solve very annoying issue when socket is not active actually but no disconnection message was arrived.

The story is waiting for a hero.
Unfortunately right now I'm working on other issues: YARL incorporating and nested sub-applications.

[brentspell]

It appears that the websocket timeout is not being honored during reads.

https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/client_ws.py#L129

This can be worked around by wrapping the receive*_ call with asyncio.wait_for, but the websocket client should do this internally.

[fafhrd91]

Good catch. Question should we use two separate timeout parameters, one for receive and another for close or same for both?

[brentspell]

That is a good question. It would probably make sense to use different timeouts for close/receive. However, for backward compatibility, the existing timeout parameter would need to be used for the close timeout, since the current receive timeout is effectively infinite. So, creating a new receive_timeout parameter with a default of None (infinite) would probably be the safest approach.

It would also be useful to allow passing a timeout to the receive_* function that could override the default. This would be analogous to the timeout parameter in ClientSession.request.

[rutsky]

Related: #777 , #1024 .

[fafhrd91]

added receive_timeout to server and client in master

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.