Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server request's state is not cloned. #2284

Closed
asvetlov opened this issue Sep 21, 2017 · 1 comment
Closed

Server request's state is not cloned. #2284

asvetlov opened this issue Sep 21, 2017 · 1 comment
Labels
bug good first issue Good for newcomers outdated
Milestone
2.3

Comments

@asvetlov
Copy link
Member

req.clone() call doesn't clone request state, changes made by req['key'] = val are not propagated to clone.

The solution is calling req._state.copy() in clone
@asvetlov asvetlov added bug good first issue Good for newcomers labels Sep 21, 2017
@asvetlov asvetlov added this to the 2.3 milestone Sep 21, 2017
@asvetlov asvetlov mentioned this issue Sep 21, 2017
Closed
asvetlov added a commit that referenced this issue Sep 23, 2017
@asvetlov
Fix #2284: Clone web request's state
4dd1621
@asvetlov asvetlov mentioned this issue Sep 23, 2017
Merged
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug good first issue Good for newcomers outdated
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
1 participant
@asvetlov