-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GunicornWebWorker: Support for unix domain sockets #470
Comments
originally i wrote wsgi compatible gunicorn worker. right now i do not have enough time to unify both workers and submit to gunicorn repo. |
asvetlov
added a commit
that referenced
this issue
Jan 29, 2016
Fixed by 1ac5e26 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
At the moment
GunicornWebWorker
doesn't support unix domain sockets. I think it can be fixed by checking for socket type and not settinghost
andport
for unix domain sockets. Something like:From other side I am really not sure, why does
ServerHttpProtocol
containshost
andport
. They are not used and probably not needed. So better solution would probably be to remove them completely. But it will break backwards compatibility though.If you think either of this solutions is fine, let me know and I'll provide a pull request.
As a side question I want to ask why does
aiohttp
has it's own worker instead of being compatible with the WSGI spec and Gunicorn'sgaiohttp
worker? I found this comment, but it was never answered...The text was updated successfully, but these errors were encountered: