You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment GunicornWebWorkerdoesn't support unix domain sockets. I think it can be fixed by checking for socket type and not setting host and port for unix domain sockets. Something like:
@asyncio.coroutine
def _run(self):
for sock in self.sockets:
if isinstance(sock, gunicorn.sock.UnixSocket):
handler = self.make_handler(self.wsgi, "", 0)
else:
handler = self.make_handler(self.wsgi, *sock.cfg_addr)
srv = yield from self.loop.create_server(handler, sock=sock.sock)
self.servers[srv] = handler
...
From other side I am really not sure, why does ServerHttpProtocol contains host and port. They are not used and probably not needed. So better solution would probably be to remove them completely. But it will break backwards compatibility though.
If you think either of this solutions is fine, let me know and I'll provide a pull request.
As a side question I want to ask why does aiohttp has it's own worker instead of being compatible with the WSGI spec and Gunicorn's gaiohttp worker? I found this comment, but it was never answered...
The text was updated successfully, but these errors were encountered:
At the moment
GunicornWebWorker
doesn't support unix domain sockets. I think it can be fixed by checking for socket type and not settinghost
andport
for unix domain sockets. Something like:From other side I am really not sure, why does
ServerHttpProtocol
containshost
andport
. They are not used and probably not needed. So better solution would probably be to remove them completely. But it will break backwards compatibility though.If you think either of this solutions is fine, let me know and I'll provide a pull request.
As a side question I want to ask why does
aiohttp
has it's own worker instead of being compatible with the WSGI spec and Gunicorn'sgaiohttp
worker? I found this comment, but it was never answered...The text was updated successfully, but these errors were encountered: