Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo in payload.py class AsyncIterablePayload error message #7351

Closed
1 task done
jrobbins-LiveData opened this issue Jul 8, 2023 · 1 comment · Fixed by #7370
Closed
1 task done

typo in payload.py class AsyncIterablePayload error message #7351

jrobbins-LiveData opened this issue Jul 8, 2023 · 1 comment · Fixed by #7370
Labels
bug

Comments

@jrobbins-LiveData
Copy link

Describe the bug

aiohttp/aiohttp/payload.py

Line 419 in bf9d753

"collections.abc.AsyncIterablebe interface, "
has a typo in place of the intended collections.abc.AsyncIterable.

To Reproduce

N/A

Expected behavior

N/A

Logs/tracebacks

N/A

Python Version

$ python --version
Python 3.9.13

aiohttp Version

$ python -m pip show aiohttp
Version: 3.8.4

multidict Version

$ python -m pip show multidict
Version: 6.0.4

yarl Version

$ python -m pip show yarl
Version: 1.9.2

OS

Windows 10

Related component

Client

Additional context

No response

Code of Conduct

  • I agree to follow the aio-libs Code of Conduct
@abdulaev-sh-m
Copy link
Contributor

#7370

@Dreamsorcerer Dreamsorcerer mentioned this issue Jul 18, 2023
Merged
5 tasks
This was referenced Jul 18, 2023
Merged
Merged
Dreamsorcerer pushed a commit that referenced this issue Jul 18, 2023
@patchback @abdulaev-sh-m
[PR #7370/22c264ce backport][3.9] fix: Spelling error fixed (#7372)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
bfae19c 
**This is a backport of PR #7370 as merged into master
(22c264c).**

<!-- Thank you for your contribution! -->

## What do these changes do?

Fixes #7351 

## Are there changes in behavior for the user?

<!-- Outline any notable behaviour for the end users. -->

## Related issue number

<!-- Are there any issues opened that will be resolved by merging this
change? -->

## Checklist

- [x] I think the code is well written
- [x] Unit tests for the changes exist
- [x] Documentation reflects the changes
- [x] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`
  * The format is &lt;Name&gt; &lt;Surname&gt;.
  * Please keep alphabetical order, the file is sorted by names.
- [x] Add a new news fragment into the `CHANGES` folder
  * name it `<issue_id>.<type>` for example (588.bugfix)
* if you don't have an `issue_id` change it to the pr id after creating
the pr
  * ensure type is one of the following:
    * `.feature`: Signifying a new feature.
    * `.bugfix`: Signifying a bug fix.
    * `.doc`: Signifying a documentation improvement.
    * `.removal`: Signifying a deprecation or removal of public API.
* `.misc`: A ticket has been closed, but it is not of interest to users.
* Make sure to use full sentences with correct case and punctuation, for
example: "Fix issue with non-ascii contents in doctest text files."

Co-authored-by: Shamil Abdulaev <112097588+abdulaev-sh-m@users.noreply.github.com>
Dreamsorcerer pushed a commit that referenced this issue Jul 18, 2023
@patchback @abdulaev-sh-m
[PR #7370/22c264ce backport][3.8] fix: Spelling error fixed (#7371)
01d9b70 
**This is a backport of PR #7370 as merged into master
(22c264c).**

<!-- Thank you for your contribution! -->

## What do these changes do?

Fixes #7351 

## Are there changes in behavior for the user?

<!-- Outline any notable behaviour for the end users. -->

## Related issue number

<!-- Are there any issues opened that will be resolved by merging this
change? -->

## Checklist

- [x] I think the code is well written
- [x] Unit tests for the changes exist
- [x] Documentation reflects the changes
- [x] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`
  * The format is &lt;Name&gt; &lt;Surname&gt;.
  * Please keep alphabetical order, the file is sorted by names.
- [x] Add a new news fragment into the `CHANGES` folder
  * name it `<issue_id>.<type>` for example (588.bugfix)
* if you don't have an `issue_id` change it to the pr id after creating
the pr
  * ensure type is one of the following:
    * `.feature`: Signifying a new feature.
    * `.bugfix`: Signifying a bug fix.
    * `.doc`: Signifying a documentation improvement.
    * `.removal`: Signifying a deprecation or removal of public API.
* `.misc`: A ticket has been closed, but it is not of interest to users.
* Make sure to use full sentences with correct case and punctuation, for
example: "Fix issue with non-ascii contents in doctest text files."

Co-authored-by: Shamil Abdulaev <112097588+abdulaev-sh-m@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Spelling error fixed
2 participants
@jrobbins-LiveData @abdulaev-sh-m