-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of serializing headers #10014
Conversation
Avoids ref counting in `to_str` since Cython can use a fast Py_TYPE check instead Only call `to_str` once per each key and value
260ef22
to
e4660b7
Compare
CodSpeed Performance ReportMerging #10014 will improve performances by 27.66%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10014 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 121 121
Lines 36727 36727
Branches 4384 4384
=======================================
Hits 36261 36261
Misses 314 314
Partials 152 152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #10015 🤖 @patchback |
(cherry picked from commit 50d23ae)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10016 🤖 @patchback |
(cherry picked from commit 50d23ae)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10017 🤖 @patchback |
(cherry picked from commit 50d23ae)
…g headers (#10016) Co-authored-by: J. Nick Koston <nick@koston.org>
…g headers (#10017) Co-authored-by: J. Nick Koston <nick@koston.org>
…g headers (#10015) Co-authored-by: J. Nick Koston <nick@koston.org>
to_str
since Cython can use a fastPy_TYPE
checkto_str
once per each key and value