Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer creation of cookies for client responses until needed #10029

Merged
merged 4 commits into from
Nov 24, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 24, 2024

Defer creation of cookies for client responses until needed

Looks to be a bit faster if there are no cookies and saves some RAM if there are not
Screenshot 2024-11-23 at 7 51 58 PM
Screenshot 2024-11-23 at 7 51 55 PM

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (cdc01cd) to head (4eecdbc).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10029   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         121      121           
  Lines       36754    36769   +15     
  Branches     4388     4392    +4     
=======================================
+ Hits        36289    36304   +15     
  Misses        314      314           
  Partials      151      151           
Flag Coverage Δ
CI-GHA 98.62% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.31% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.14% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.41% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.25% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.84% <100.00%> (+0.04%) ⬆️
Py-3.11.10 97.84% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.31% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 98.37% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 98.35% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.18% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.76% <100.00%> (+0.04%) ⬆️
Py-pypy7.3.16 97.33% <100.00%> (+<0.01%) ⬆️
VM-macos 97.41% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.31% <100.00%> (+<0.01%) ⬆️
VM-windows 96.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Nov 24, 2024

CodSpeed Performance Report

Merging #10029 will not alter performance

Comparing lazy_cookies_client_response (4eecdbc) with master (cdc01cd)

Summary

✅ 44 untouched benchmarks

@bdraco bdraco added backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Nov 24, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 24, 2024
@bdraco bdraco changed the title DNM: Defer creation of cookies for client responses until needed Defer creation of cookies for client responses until needed Nov 24, 2024
@bdraco bdraco marked this pull request as ready for review November 24, 2024 18:35
@bdraco bdraco merged commit 5f5729d into master Nov 24, 2024
40 checks passed
@bdraco bdraco deleted the lazy_cookies_client_response branch November 24, 2024 18:35
Copy link
Contributor

patchback bot commented Nov 24, 2024

Backport to 3.11: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 5f5729d on top of patchback/backports/3.11/5f5729d2db02c5643e2e4e33d840b623a1af9c48/pr-10029

Backporting merged PR #10029 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.11/5f5729d2db02c5643e2e4e33d840b623a1af9c48/pr-10029 upstream/3.11
  4. Now, cherry-pick PR Defer creation of cookies for client responses until needed #10029 contents into that branch:
    $ git cherry-pick -x 5f5729d2db02c5643e2e4e33d840b623a1af9c48
    If it'll yell at you with something like fatal: Commit 5f5729d2db02c5643e2e4e33d840b623a1af9c48 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 5f5729d2db02c5643e2e4e33d840b623a1af9c48
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Defer creation of cookies for client responses until needed #10029 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.11/5f5729d2db02c5643e2e4e33d840b623a1af9c48/pr-10029
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 24, 2024

Backport to 3.12: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 5f5729d on top of patchback/backports/3.12/5f5729d2db02c5643e2e4e33d840b623a1af9c48/pr-10029

Backporting merged PR #10029 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.12/5f5729d2db02c5643e2e4e33d840b623a1af9c48/pr-10029 upstream/3.12
  4. Now, cherry-pick PR Defer creation of cookies for client responses until needed #10029 contents into that branch:
    $ git cherry-pick -x 5f5729d2db02c5643e2e4e33d840b623a1af9c48
    If it'll yell at you with something like fatal: Commit 5f5729d2db02c5643e2e4e33d840b623a1af9c48 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 5f5729d2db02c5643e2e4e33d840b623a1af9c48
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Defer creation of cookies for client responses until needed #10029 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.12/5f5729d2db02c5643e2e4e33d840b623a1af9c48/pr-10029
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

bdraco added a commit that referenced this pull request Nov 24, 2024
bdraco added a commit that referenced this pull request Nov 24, 2024
bdraco added a commit that referenced this pull request Nov 24, 2024
bdraco added a commit that referenced this pull request Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant